Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Incorrect list of symbols in PHP #118

Closed
sebastien-gallet opened this issue Jan 17, 2016 · 4 comments
Closed

Incorrect list of symbols in PHP #118

sebastien-gallet opened this issue Jan 17, 2016 · 4 comments

Comments

@sebastien-gallet
Copy link

In PHP, if a function name first character is lowercased and the parameter is a strongly typed initialized array:
screen shot 2016-01-17 at 10 59 52 am

Then pressing the shortcut "Goto Symbol", the list of symbols shows the parameter name instead of the function name.
(As a side note, somehow it pick "name" in the comment as a symbol as well.)
screen shot 2016-01-17 at 11 00 00 am

@tommyvdv
Copy link

I believe i'm having the same issue in this example and hope a few extra examples can help you pinpoint the source of the problem.

1

2

3

The symbol definition for an optional parameter named $locale seems to override the method name.

In dense classes i'm also getting some hits on the code inside methods. This makes it hard to navigate some files. Disregard this if this behavior is intentional (I'm new to Atom and was a sublime user).

4

edit: I've discovered that the package goto solves the inaccurate symbols.

@bj7
Copy link
Contributor

bj7 commented May 7, 2016

I also experience an issue with the symbol list not being correct in PHP files. I have a function:
image
When using Command-R (Mac) and searching on view, all I get back is the name of my class:
image

Which file handles symbol list definitions? I would be glad to investigate.

@winstliu
Copy link
Contributor

winstliu commented May 7, 2016

This issue was moved to atom/symbols-view#175

@winstliu
Copy link
Contributor

winstliu commented May 7, 2016

Fairly certain that symbols-view handles this so I've moved the issue over there.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants