Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Incorrect list of symbols in PHP #175

Open
winstliu opened this issue May 7, 2016 · 9 comments
Open

Incorrect list of symbols in PHP #175

winstliu opened this issue May 7, 2016 · 9 comments
Labels

Comments

@winstliu
Copy link
Contributor

winstliu commented May 7, 2016

From @sebastien-gallet on January 17, 2016 2:40

In PHP, if a function name first character is lowercased and the parameter is a strongly typed initialized array:
screen shot 2016-01-17 at 10 59 52 am

Then pressing the shortcut "Goto Symbol", the list of symbols shows the parameter name instead of the function name.
(As a side note, somehow it pick "name" in the comment as a symbol as well.)
screen shot 2016-01-17 at 11 00 00 am

Copied from original issue: atom/language-php#118

@winstliu
Copy link
Contributor Author

winstliu commented May 7, 2016

From @tommyvdv on January 25, 2016 14:55

I believe i'm having the same issue in this example and hope a few extra examples can help you pinpoint the source of the problem.

1

2

3

The symbol definition for an optional parameter named $locale seems to override the method name.

In dense classes i'm also getting some hits on the code inside methods. This makes it hard to navigate some files. Disregard this if this behavior is intentional (I'm new to Atom and was a sublime user).

4

edit: I've discovered that the package goto solves the inaccurate symbols.

@winstliu
Copy link
Contributor Author

winstliu commented May 7, 2016

From @bj7 on May 7, 2016 17:46

I also experience an issue with the symbol list not being correct in PHP files. I have a function:
image
When using Command-R (Mac) and searching on view, all I get back is the name of my class:
image

Which file handles symbol list definitions? I would be glad to investigate.

@hultberg
Copy link

hultberg commented Jun 2, 2016

I'm seeing this issue all the time. I also struggle to find several methods in big classes. I end up just searching for them with cmd+f

@bj7
Copy link

bj7 commented Jun 6, 2016

I'll try to take a look at this in my spare time to determine a cause.

@mcdado
Copy link

mcdado commented Aug 19, 2016

Moreover, declaration of class properties are reported as symbols, just like local variables inside class methods!

screen shot 2016-08-19 at 21 21 02

This makes symbols-view in php almost useless.

@nathanpitman
Copy link

I've had the same issue, as someone switching from Sublime the behaviour of Cmd-R is not what I expected and pretty much useless. The Goto package is perfect though. :)

@godcong
Copy link

godcong commented Dec 30, 2016

happy new year issus

@pablopunk
Copy link

@50Wliu any plans on this issue? It's a big deal when I use atom at work

@winstliu
Copy link
Contributor Author

Nope. Anyone is free to investigate this issue and submit a PR though.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

7 participants