This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Added .mysql to list of relevant files #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Requirements Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion. All new code requires tests to ensure against regressions Description of the Change Added 'mysql' to list of file endings to work with. Alternate Designs Users have to try to change that on their end? Benefits Just as people use pgsql for postgres people use .mysql for mysql/mariadb files. Now they are colorized etc, without needing to be renamed to .sql. Possible Drawbacks Namespace collision? Expectation of specific action for mysql files? There is a fork that adds mysql specific stuff. Perhaps that's the right approach? https://atom.io/packages/language-sql-mysql Applicable Issues
|
can this be updated to a generic request for user defined file extensions? I like to use this for plsql, and I often have .pkb/.pks/.pls and other things that may not be applicable for everyone |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Added 'mysql' to list of file endings to work with.
Alternate Designs
Users have to try to change that on their end? Install forked and possibly not maintained version just for mysql: https://atom.io/packages/language-sql-mysql I'd prefer plugin to do its best guess for mysql.
Benefits
Just as people use pgsql for postgres people use .mysql for mysql/mariadb files. Now they are colorized etc, without needing to be renamed to .sql.
Possible Drawbacks
Namespace collision? Expectation of specific action for mysql files? There is a fork that adds mysql specific stuff. Perhaps that's the right approach? https://atom.io/packages/language-sql-mysql
Applicable Issues
None.