Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes for vite / vitest builds #58

Merged
merged 5 commits into from
Dec 19, 2024
Merged

fixes for vite / vitest builds #58

merged 5 commits into from
Dec 19, 2024

Conversation

seanrcollings
Copy link
Contributor

@seanrcollings seanrcollings commented Dec 13, 2024

vitest has to use node's dependency resolution strategies, which don't always work the same way you'd expect that vite normally worked when bundling dependencies. This PR:

  • Swaps @atomicjolt/hooks to build to es modules instead of common js
  • Adds some additional metadata in the package.json to help node
  • Includes the source TS assets in the final bundle for elements & hooks so that sourcemaps produced during the build actually point to something. This is not strictly necessary, but it stops vitest from emitting a bunch of warnings about missing source files & it should improve developer experience as the source files are actually present.

@seanrcollings seanrcollings merged commit ef1bed0 into main Dec 19, 2024
1 check passed
@seanrcollings seanrcollings deleted the sc/vite-fixes branch December 19, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants