Add models and helpers for multi tenancy #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is intended to be a replacement for Apartment using row level security. It has helpers for enabling row level security, and methods for switching tenants that can replace the existing apartment methods fairly seamlessly. It also has a module that can be used to set whether a model is tenanted or not, and a helper to check for whether a model is tenanted.
This was from this code originally being in ApplicationRecord and then being copied out.
We removed the tenant_id thread variable in favor of just storing the entire tenant object
Also use the relationship on ApplicationInstance to get the tenant
Make the user name configurable, as well as what table is used for the tenants.
It's shorter
mpetrowi
approved these changes
Nov 21, 2024
| end | ||
|
|
||
| def self.switch_tenant_legacy(tenant_key, &block) | ||
| tenant = AtomicTenant.tenant_model.find_by(key: tenant_key) |
There was a problem hiding this comment.
We should check it exists, otherwise I think we will get switched to public
lib/atomic_tenant/tenantable.rb
Outdated
| super | ||
|
|
||
| if subclass <= ActiveRecord::Base && !subclass.abstract_class? | ||
| AtomicTenant::Tenantable.register_private_tenanted_model(subclass) |
There was a problem hiding this comment.
Clever. There are a lot of things in this function I've never seen before
schema.rb doesn't have the row level security policies, so if the database is loaded from it in CI or locally then it won't have them either.
These weren't real vulnerabilities, but it's easy enough to make Brakeman happy.
This will preserve RLS policies
This was creating 'rls."tenant_id"' which is not what we want.
This method is meant to be used from within the class, not externally
jbasdf
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to be a replacement for Apartment using row level security. It has helpers for enabling row level security, and methods for switching tenants that can replace the existing apartment methods fairly seamlessly. It also has a module that can be used to set whether a model is tenanted or not, and a helper to check for whether a model is tenanted.