WIP - Course copy changes #412
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move lti_launches to global schema - Add lti_contexts and lti_platform_instances tables
For LTI 1.2 launches, we won't have a deployment_id, so add a unique index by context_id with deployment_id null.
dspencer001
reviewed
Jan 22, 2021
| @@ -189,6 +189,10 @@ def set_lti_launch_values | |||
| @is_lti_launch = true | |||
| @canvas_url = current_application_instance.site.url | |||
| @app_name = current_application_instance.application.client_application_name | |||
| context_id = params[:context_id] | |||
| if current_user&.can_author?(context_id, current_application_instance) | |||
| @can_author = true | |||
There was a problem hiding this comment.
This seems like it may be AA specific that accidentally got merged in upstream? I can see the method exists on the user as well, which is kinda weird.
There was a problem hiding this comment.
Here it means the lti roles are teacher or admin, which I'm using to determine when the user can resolve a launch issue. There might be a better way to do this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress of some changes to support course copy