Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skip call when logging with fields at all levels #1

Merged
merged 2 commits into from
Apr 21, 2023

Conversation

kuujo
Copy link
Member

@kuujo kuujo commented Apr 21, 2023

This PR fixes a bug in the caller output due to needing to skip another caller level when using the *w logger methods.

@kuujo kuujo added the bug Something isn't working label Apr 21, 2023
@kuujo kuujo requested a review from adibrastegarnia April 21, 2023 21:33
@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Merging #1 (a3c51c4) into master (eca922a) will increase coverage by 0.52%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master       #1      +/-   ##
==========================================
+ Coverage   66.24%   66.76%   +0.52%     
==========================================
  Files          15       15              
  Lines        1730     1730              
==========================================
+ Hits         1146     1155       +9     
+ Misses        495      486       -9     
  Partials       89       89              
Impacted Files Coverage Δ
logger.go 69.00% <66.66%> (+2.42%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kuujo kuujo merged commit c0da15a into master Apr 21, 2023
@kuujo kuujo deleted the log-with-fields-skip-call branch April 21, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants