Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spellcheck .Rmd files #153

Closed
bms63 opened this issue Jun 8, 2023 · 1 comment · Fixed by #156
Closed

Spellcheck .Rmd files #153

bms63 opened this issue Jun 8, 2023 · 1 comment · Fixed by #156
Milestone
xportr 0.3.0

Comments

@bms63
Copy link
Collaborator

bms63 commented Jun 8, 2023

Currently we do not check .Rmd files.

xportr/.github/workflows/spellcheck.yml

Line 64 in 95966e5

exclude: data/*,**/*.Rd,**/*.Rmd,**/*.md,*.md

Definition of Done

Remove .Rmd from excludes.
@bms63
Copy link
Collaborator Author

bms63 commented Jun 8, 2023

@atorus-research/xportr-development-team anyone want to get their hands dirty with working on GitHub Actions. Really simple fix, but nice to get some practice with GitHub ACtions/CI stuff :)

@bms63 bms63 added this to the xportr 0.3.0 milestone Jun 8, 2023
@bms63 bms63 moved this to Priority in xportr 0.3.0 Jun 8, 2023
@bms63 bms63 mentioned this issue Jun 13, 2023
Merged
@vedhav vedhav linked a pull request Jun 13, 2023 that will close this issue
chore: remove styler from the package suggests #156
Merged
@bms63 bms63 moved this from Priority to In Review in xportr 0.3.0 Jun 13, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in xportr 0.3.0 Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
xportr 0.3.0
Status: Done
Milestone
xportr 0.3.0
Development

Successfully merging a pull request may close this issue.

chore: remove styler from the package suggests atorus-research/xportr
2 participants
@bms63 @elimillera