Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove styler from the package suggests #156

Merged
merged 4 commits into from
Jun 13, 2023
Merged

chore: remove styler from the package suggests #156

merged 4 commits into from
Jun 13, 2023

Conversation

vedhav
Copy link
Collaborator

@vedhav vedhav commented Jun 13, 2023 •
edited
Loading

Closes:

Changes:

  1. Removes {styler} from the Suggests. Since the CI already installs this in a step we don't need to worry about it.
  2. Remove .Rmd files from being ignored in the Spell check GitHub actions.

@vedhav vedhav requested review from averissimo and bms63 June 13, 2023 12:29
@vedhav vedhav linked an issue Jun 13, 2023 that may be closed by this pull request
Remove {styler} dependency #140
Closed
@bms63
Copy link
Collaborator

bms63 commented Jun 13, 2023

Do you mind updating the spellcheck to look at ..Rmd files in this PR as well please? :) #153

@vedhav vedhav linked an issue Jun 13, 2023 that may be closed by this pull request
Spellcheck .Rmd files #153
Closed
@elimillera elimillera merged commit e12b1a7 into devel Jun 13, 2023
@elimillera elimillera deleted the 140_remove_styler branch June 13, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elimillera elimillera elimillera approved these changes

@averissimo averissimo Awaiting requested review from averissimo

@bms63 bms63 Awaiting requested review from bms63

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spellcheck .Rmd files Remove {styler} dependency
3 participants
@vedhav @bms63 @elimillera