Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix public key signing. #76

Merged
merged 5 commits into from
Jan 7, 2025
Merged

Fix public key signing. #76

merged 5 commits into from
Jan 7, 2025

Conversation

mcdee
Copy link
Contributor

@mcdee mcdee commented Jan 7, 2025

Replacement for #75 with additional fixes and coverage.

@mcdee mcdee mentioned this pull request Jan 7, 2025
@mcdee mcdee requested a review from Bez625 January 7, 2025 10:40
Bez625
Bez625 previously approved these changes Jan 7, 2025
@Bez625 Bez625 dismissed their stale review January 7, 2025 14:22

Missed the deepsource failure

@mcdee
Copy link
Contributor Author

mcdee commented Jan 7, 2025

It's just a big case statement, I don't see that breaking it into smaller chunks will help at this stage so I think we ignore it.

@mcdee mcdee merged commit 48a4875 into master Jan 7, 2025
2 of 3 checks passed
@mcdee mcdee deleted the pubkey-signing branch January 7, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants