This repository has been archived by the owner on Aug 28, 2021. It is now read-only.
Proposal for new numbers support in Noms #3806
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 3, 2018
Closed
Closed
Closed
aboodman
commented
Jun 3, 2018
| Where: | ||
|
|
||
| - `np`: numerator precision (signed integer) | ||
| - `ne`: numerator exponent (unsigned integer) |
There was a problem hiding this comment.
Shoot, ne needs to be able to go negative, for values between 0 and 0.5.
aboodman
force-pushed
the
aboodman-numbers
branch
from
ad17a82 to
19ad60b
Compare
|
I think there are a bunch of problems with this, so I'm going to back up and start at desired features in a bug. |
|
Collecting requirements here: #3807 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have been a number of request for better support for numeric types in Noms (#3801, #3802). With the benefit of some time away, I had some inspiration about how this should work.
I've created this start at a proposal. If you have feedback, please leave it here on the PR.
Eventually I will commit this in the proposal directory, and then (given energy/motivation) implement it and move the doc up to he docs directory when it is complete.