Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change translation api's protocol from http to https #75

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shigemk2
Copy link
Contributor

@shigemk2 shigemk2 commented Oct 1, 2017

@pierwill
Copy link

This would be nice to merge :)

@atykhonov
Copy link
Owner

Sure this one should be merged asap. v0.11.15 has been just released. Will see how it will be going and come back to this issue in order to merge and release. @pierwill @shigemk2 thank you!

@ylluminarious
Copy link

@atykhonov Thanks so much for this great package! This will make certain translation tasks much easier for me. Everything seems perfect so far, with this being the only flaw. I would appreciate it very much if you could merge this.

@atykhonov
Copy link
Owner

I just tried the changes. Text translation works well, but sound translation doesn't work at all. And for now I don't see how to (quickly) fix this. Does it work for you?

@atykhonov
Copy link
Owner

atykhonov commented Oct 19, 2018

It looks like that I have some local issues when I play a sound (https-version) by means of mplayer or vlc (google-translate uses mplayer by default). For example, vlc reports an error "TLS client plugin not available". I can fix it and I will, but I think that these changes introduce a potential issue when a user doesn't have a player with TLS/SSL support and he cannot add that support. Also, I'm not sure how well the changes (for both, text and sound translations) will work on Windows machines (again the main concern is TLS/SSL support).

Overall, the idea is good, I think that google-translate should support these feature but it should be configurable by means of a flag that indicates which version to use: plain HTTP or HTTP over TLS/SSL (so, if you need encrypted communication you could turn it on). The default configuration should use insecure HTTP.

@ylluminarious
Copy link

@atykhonov That sounds reasonable to me.

@atykhonov
Copy link
Owner

@ylluminarious thanks for your feedback! I'll do my best to implement the feature in the nearest future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants