This repository has been archived by the owner on Jun 16, 2024. It is now read-only.
new cover options #79
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbiet480
suggested changes
Jul 20, 2017
| @@ -0,0 +1,3 @@ | |||
| { | |||
There was a problem hiding this comment.
Please remove this file
haaska.py
Outdated
| @@ -452,6 +452,14 @@ def turn_on(self): | |||
| def turn_off(self): | |||
| self._call_service('cover/close_cover') | |||
|
|
|||
| def set_percentage(self, val): | |||
| self._call_service('cover/set_cover_position', {'position':val}) | |||
There was a problem hiding this comment.
haaska.py:456:67: E231 missing whitespace after ':'
haaska.py
Outdated
| @@ -452,6 +452,14 @@ def turn_on(self): | |||
| def turn_off(self): | |||
| self._call_service('cover/close_cover') | |||
|
|
|||
| def set_percentage(self, val): | |||
| self._call_service('cover/set_cover_position', {'position':val}) | |||
|
|
|||
There was a problem hiding this comment.
haaska.py:457:1: W293 blank line contains whitespace
|
now, everything is fine ;) |
philk
reviewed
Aug 12, 2017
|
|
||
| def get_percentage(self): | ||
| state = self.ha.get('states/' + self.entity_id) | ||
| value = int(state['current_position']) |
There was a problem hiding this comment.
Not all covers report their current_position (specifically Somfy zwave blinds). I'm doing a terrible hack to make this work on my system:
def get_percentage(self):
return 50
def set_percentage(self, val):
if val > 50:
self._call_service('cover/open_cover')
if val < 50:
self._call_service('cover/close_cover')Definitely not saying to do that but you need to check if current_position is None to be safe here.
|
Any ideas on how to implement stop cover? My patio awning never need to extend fully, needs a stop command badly. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Cover Position to haaska