Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add selected icon feature for tab bar item #276

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add selected icon feature for tab bar item #276

wants to merge 3 commits into from

Conversation

bbdroid
Copy link

@bbdroid bbdroid commented Aug 20, 2017

Solved Problem

We can't apply selected icon for tab bar item.

Test

Set force tint as either false or true.

bottomNavigation.setForceTint(false);

false : ignore tint color, apply selected icon
true : apply tint color, ignore selected icon

Set selected icon as third parameter.

AHBottomNavigationItem item1 = new AHBottomNavigationItem(R.string.tab_1, R.drawable.map, R.drawable.map_selected, R.color.color_tab_1);

If you set force tint flag as false, selected icon will be applied.
If it's true, selected icon will be ignored. And tint colour will be used for selected state.

@Rainer-Lang
Copy link

@bdavid68 @aurelhubert I would really appreciate to get this merged. Any chance?

@bmc08gt
Copy link

bmc08gt commented Oct 1, 2017

This feature would be great for my current usecase

@bbdroid
Copy link
Author

bbdroid commented Oct 2, 2017

@aurelhubert @bmc08gt I am not sure why @aurelhubert doesn't merge this PR.

@Crash--
Copy link

Crash-- commented Nov 20, 2017

@aurelhubert What do you think of this PR? Is it ok for you or do we need to fix some stuff?

Copy link

@seba1342 seba1342 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delicious work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants