feat: getting rid of json serialization and near_sdk (#13)

Cargo.toml

@@ -20,13 +20,13 @@ members = [
 
 [workspace.dependencies]
 anyhow = "1"
-aurora-engine-types = "1"
+aurora-engine-types = { git = "https://github.com/aurora-is-near/aurora-engine", rev = "fbe7f33", default-features = false }
 ethabi = "18"
-near-sdk = "4.1"
+near-sdk = "5"
 near-plugins = { git = "https://github.com/aurora-is-near/near-plugins", tag = "v0.2.0" }
 once_cell = "1"
 serde = { version = "1", features = ["derive"] }
-near-workspaces = "0.9"
+near-workspaces = "0.10"
 tokio = { version = "1", features = ["macros"] }
 
 [profile.release]
@@ -36,6 +36,3 @@ lto = true
 debug = false
 panic = "abort"
 overflow-checks = true
-
-[patch.crates-io]
-parity-secp256k1 = { git = 'https://github.com/paritytech/rust-secp256k1', rev = "d05fd8e" }

Makefile.toml

@@ -43,26 +43,38 @@ args = [
     "--all-targets"
 ]
 
-[tasks.build-contracts]
+[tasks.build-forwarder]
 command = "cargo"
 env = { "RUSTFLAGS" = "-C link-arg=-s" }
 args = [
     "build",
     "--target",
     "${TARGET}",
     "--release",
-    "--workspace",
-    "--exclude",
-    "aurora-forwarder-tests",
-    "--exclude",
-    "aurora-forwarder-factory"
+    "--package",
+    "aurora-forwarder"
+]
+
+[tasks.build-fees]
+command = "cargo"
+env = { "RUSTFLAGS" = "-C link-arg=-s" }
+args = [
+    "build",
+    "--target",
+    "${TARGET}",
+    "--release",
+    "--package",
+    "aurora-forward-fees",
 ]
 
+[tasks.build-contracts]
+dependencies = ["build-forwarder", "build-fees"]
+
 [tasks.optimize-contracts]
 dependencies = ["download-wasm-opt"]
 script = '''
    filesize_before=$(wc -c res/${FWD_WASM_FILE} | awk '{print $1}')
-   res/binaryen/bin/wasm-opt -O4 res/${FWD_WASM_FILE} -o res/${FWD_WASM_FILE} --strip-debug --vacuum
+   res/binaryen/bin/wasm-opt -Os res/${FWD_WASM_FILE} -o res/${FWD_WASM_FILE}
    filesize_after=$(wc -c res/${FWD_WASM_FILE} | awk '{print $1}')
    echo "File size before: [$filesize_before] and after: [$filesize_after]"
  '''

factory/Cargo.toml

@@ -18,5 +18,6 @@ nursery = "deny"
 pedantic = "deny"
 
 [dependencies]
+aurora-engine-types.workspace = true
 forwarder-utils = { path = "../utils" }
 near-sdk.workspace = true

factory/src/lib.rs

@@ -1,18 +1,21 @@
+use aurora_engine_types::types::Address;
 use near_sdk::borsh::{self, BorshDeserialize, BorshSerialize};
 use near_sdk::serde::{Deserialize, Serialize};
-use near_sdk::serde_json::json;
 use near_sdk::{
-    assert_self, env, ext_contract, near_bindgen, AccountId, Balance, Gas, PanicOnDefault, Promise,
+    assert_self, env, ext_contract, near_bindgen, AccountId, Gas, NearToken, PanicOnDefault,
+    Promise,
 };
 
 const FORWARDER_WASM: &[u8] = include_bytes!("../../res/aurora-forwarder.wasm");
-const INIT_BALANCE: Balance = 1_530_000_000_000_000_000_000_000;
-const STORAGE_BALANCE_BOUND: Balance = 1_250_000_000_000_000_000_000;
-const FORWARDER_NEW_GAS: Gas = Gas(1_000_000_000_000);
-const MAX_NUM_CONTRACTS: usize = 8;
+const STORAGE_BALANCE_BOUND: NearToken = NearToken::from_yoctonear(1_250_000_000_000_000_000_000);
+const FORWARDER_NEW_GAS: Gas = Gas::from_tgas(2);
+
+pub const MAX_NUM_CONTRACTS: usize = 12;
+pub const INIT_BALANCE: NearToken = NearToken::from_millinear(360);
 
 #[near_bindgen]
 #[derive(BorshDeserialize, BorshSerialize, PanicOnDefault)]
+#[borsh(crate = "near_sdk::borsh")]
 pub struct AuroraForwarderFactory {
     owner: AccountId,
     fees_contract_id: AccountId,
@@ -22,6 +25,7 @@ pub struct AuroraForwarderFactory {
 impl AuroraForwarderFactory {
     #[init]
     #[must_use]
+    #[allow(clippy::use_self)]
     pub fn new(fees_contract_id: AccountId) -> Self {
         Self {
             owner: env::predecessor_account_id(),
@@ -55,18 +59,25 @@ impl AuroraForwarderFactory {
                     &params.target_network,
                     &self.fees_contract_id,
                 );
-                let args = near_sdk::serde_json::to_vec(&json!({
-                    "target_address": params.target_address,
-                    "target_network": params.target_network,
-                    "fees_contract_id": &self.fees_contract_id,
-                    "wnear_contract_id": params.wnear_contract_id,
-                }))
+                let args = borsh::to_vec(&ForwarderParameters {
+                    target_address: Address::decode(params.target_address.trim_start_matches("0x"))
+                        .unwrap(),
+                    target_network: &params.target_network,
+                    wnear_contract_id: &params.wnear_contract_id,
+                    fees_contract_id: &self.fees_contract_id,
+                })
                 .expect("Couldn't create args");
+
                 let _ = Promise::new(forwarder_id.clone())
                     .create_account()
                     .transfer(INIT_BALANCE)
                     .deploy_contract(FORWARDER_WASM.to_vec())
-                    .function_call("new".to_string(), args, 0, FORWARDER_NEW_GAS)
+                    .function_call(
+                        "new".to_string(),
+                        args,
+                        NearToken::from_near(0),
+                        FORWARDER_NEW_GAS,
+                    )
                     .then(
                         ext_token::ext(params.wnear_contract_id)
                             .with_attached_deposit(STORAGE_BALANCE_BOUND)
@@ -104,6 +115,15 @@ pub struct DeployParameters {
     pub wnear_contract_id: AccountId,
 }
 
+#[derive(BorshSerialize)]
+#[borsh(crate = "near_sdk::borsh")]
+pub struct ForwarderParameters<'a> {
+    pub target_address: Address,
+    pub target_network: &'a AccountId,
+    pub wnear_contract_id: &'a AccountId,
+    pub fees_contract_id: &'a AccountId,
+}
+
 fn create_forwarder_id(
     address: &str,
     network: &AccountId,

fees/Cargo.toml

@@ -17,4 +17,5 @@ nursery = "deny"
 pedantic = "deny"
 
 [dependencies]
+aurora-engine-types.workspace = true
 near-sdk.workspace = true

fees/src/lib.rs

@@ -1,4 +1,5 @@
-use near_sdk::borsh::{self, BorshDeserialize, BorshSerialize};
+use aurora_engine_types::types::Address;
+use near_sdk::borsh::{BorshDeserialize, BorshSerialize};
 use near_sdk::json_types::{U128, U64};
 use near_sdk::{env, near_bindgen, AccountId, IntoStorageKey, PanicOnDefault};
 use std::collections::BTreeSet;
@@ -14,6 +15,7 @@ const DEFAULT_PERCENT: U64 = U64(500); // 5%
 
 #[near_bindgen]
 #[derive(BorshDeserialize, BorshSerialize, PanicOnDefault)]
+#[borsh(crate = "near_sdk::borsh")]
 pub struct FeesCalculator {
     percent: Option<U64>,
     owner: AccountId,
@@ -29,6 +31,7 @@ impl FeesCalculator {
     /// The constructor panics if the state already exists.
     #[init]
     #[must_use]
+    #[allow(clippy::use_self)]
     pub fn new(tokens: Vec<AccountId>) -> Self {
         Self {
             percent: Some(DEFAULT_PERCENT),
@@ -43,12 +46,13 @@ impl FeesCalculator {
     ///
     /// There is a safe unwrap because we return 0 if the percent is None.
     #[must_use]
+    #[result_serializer(borsh)]
     pub fn calculate_fees(
         &self,
-        amount: U128,
-        token_id: &AccountId,
-        target_network: &AccountId,
-        target_address: String,
+        #[serializer(borsh)] amount: U128,
+        #[serializer(borsh)] token_id: &AccountId,
+        #[serializer(borsh)] target_network: &AccountId,
+        #[serializer(borsh)] target_address: Address,
     ) -> U128 {
         let _ = (target_network, target_address);
 
@@ -118,6 +122,7 @@ impl FeesCalculator {
 }
 
 #[derive(BorshDeserialize, BorshSerialize)]
+#[borsh(crate = "near_sdk::borsh")]
 enum KeyPrefix {
     SupportedTokens,
 }
@@ -185,6 +190,7 @@ fn validate_decimal_part(percent: &str) -> Result<(), ParseError> {
 #[cfg(test)]
 mod tests {
     use super::{parse_percent, FeesCalculator, ParseError};
+    use aurora_engine_types::types::Address;
     use near_sdk::AccountId;
 
     #[test]
@@ -216,19 +222,19 @@ mod tests {
     #[test]
     fn test_check_supported_tokens() {
         let aurora = "aurora".parse().unwrap();
-        let target_address = "0xea2342".to_string();
+        let target_address = Address::default();
         let usdt = "usdt.near".parse().unwrap();
         let mut contract = FeesCalculator::new(vec![]);
 
         assert_eq!(
-            contract.calculate_fees(1000.into(), &usdt, &aurora, target_address.clone()),
+            contract.calculate_fees(1000.into(), &usdt, &aurora, target_address),
             0.into() // we don't support the `usdt.near` yet, so we get 0 here
         );
 
         contract.add_supported_token(usdt.clone());
 
         assert_eq!(
-            contract.calculate_fees(1000.into(), &usdt, &aurora, target_address.clone()),
+            contract.calculate_fees(1000.into(), &usdt, &aurora, target_address),
             50.into()
         );
 
@@ -243,19 +249,19 @@ mod tests {
     #[test]
     fn test_check_set_fee() {
         let aurora = "aurora".parse().unwrap();
-        let target_address = "0xea2342".to_string();
+        let target_address = Address::default();
         let usdt: AccountId = "usdt.near".parse().unwrap();
         let mut contract = FeesCalculator::new(vec![usdt.clone()]);
 
         assert_eq!(
-            contract.calculate_fees(1000.into(), &usdt, &aurora, target_address.clone()),
+            contract.calculate_fees(1000.into(), &usdt, &aurora, target_address),
             50.into()
         );
 
         contract.set_fee_percent(Some("0".to_string()));
 
         assert_eq!(
-            contract.calculate_fees(1000.into(), &usdt, &aurora, target_address.clone()),
+            contract.calculate_fees(1000.into(), &usdt, &aurora, target_address),
             0.into()
         );
 

forwarder/Cargo.toml

@@ -18,5 +18,6 @@ pedantic = "deny"
 as_conversions = "deny"
 
 [dependencies]
-forwarder-utils = {path = "../utils" }
-near-sdk.workspace = true
+arrayvec = { version = "0.7", default-features = false }
+borsh = { version = "1", default-features = false, features = ["derive"] }
+hex = { version = "0.4", default-features = false }

forwarder/src/error.rs

@@ -0,0 +1,24 @@
+#[cfg_attr(not(target_arch = "wasm32"), derive(Debug, PartialEq, Eq))]
+pub enum ContractError {
+    ParseAccountError,
+    BorshDeserializeError,
+    BorshSerializeError,
+    OneYoctoAttachError,
+    PrivateCallError,
+    BadUtf8String,
+    BadNumber,
+}
+
+impl AsRef<[u8]> for ContractError {
+    fn as_ref(&self) -> &[u8] {
+        match self {
+            Self::ParseAccountError => b"ERR_PARS_ACCOUNT",
+            Self::BorshDeserializeError => b"ERR_BORCH_DESERIALIZE",
+            Self::BorshSerializeError => b"ERR_BORCH_SERIALIZE",
+            Self::OneYoctoAttachError => b"ERR_ONE_YOCTO_ATACH",
+            Self::PrivateCallError => b"ERR_PRIVATE_CALL",
+            Self::BadUtf8String => b"ERR_BAD_UTF8_STRING",
+            Self::BadNumber => b"ERR_BAD_NUMBER",
+        }
+    }
+}