feat: ensure minimal fee is more than 0 #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
calculate_feesmethod calculates the fee based on a percentage of the transaction amount. However, due to the use of integer division, any calculation that results in a value between 0 and 1 will be rounded down to 0. This means that for small amounts of the transaction, the calculated fee can be zero, effectively bypassing the intended fee mechanism. This issue primarily affects transactions involving small quantities of tokens, where the fee, although nominally applicable, is nullified by the rounding behavior of integer arithmetic.This PR proposes the next solution. When we detect that fee is computed to
0we just increase it to1.