Fix: check diff before commiting it to storage #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleksuss
approved these changes
Aug 28, 2023
| &tx_outcome.info, | ||
| &tx_outcome.diff, | ||
| )? | ||
| tx_outcome.commit(storage)? |
There was a problem hiding this comment.
Would it be better to add in the future a method to the Storage that will accept an array of txs and persist the changes atomically via WriteBatch?
There was a problem hiding this comment.
Yes, good point that would be better. I created an issue for it here so that the idea doesn't get lost.
aleksuss
pushed a commit
that referenced
this pull request
Aug 30, 2023
(cherry picked from commit 5c92fae)
aleksuss
pushed a commit
that referenced
this pull request
Aug 30, 2023
(cherry picked from commit 5c92fae)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix address the performance issue in the refiner where constantly writing and deleting the same key made reading that key slow. Now the diff of a transaction is checked before committing it to the DB so that only the correct diff is written. Related PR: aurora-is-near/aurora-engine#825