-
Notifications
You must be signed in to change notification settings - Fork 0
Test adding oras command for shpc #17
base: main
Are you sure you want to change the base?
Conversation
This is an OCI registry entry, just a different artifact type, so I think we can try parsing it the same as docker. If that does not work we can skip for now Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
okay I've tested:
This turned out not to work - lookout (or cuppa?) seemed to try and look for the reference and exit on error:
I couldn't find anywhere in either lookout or cuppa with this error message so I suspect it's coming from a dependency library. I tried returning false for found and an empty result, but that didn't work. @alecbcs what would you suggest? We likely want to get in a quick fix here so oras isn't removed from the recipe, but we also don't want the entire parsing to fail. Does oras need to be added to lookout? |
okay I'm debugging and testing in autamus/cuppa now (I always forgot about this fork!) and I'll update if I learn anything! It does look like the code here would have trouble parsing oras. |
okay I got pretty close - the registry (GitHub packages) will return tags for an oras artifact, but it doesn't seem to be able to return the image config, e.g., https://crane.ggcr.dev/config/ghcr.io/singularityhub/github-ci is empty. |
huzzah! I got the manifest to work! So this might work - going to take a break for dinner and back after. |
@alecbcs SHPC recently had the oras directive added to the container.yaml, meaning that a user can pull a singularity SIF directly from an OCI registry! Since it's an OCI registry entry and just a different artifact type, I'm thinking we can first try parsing it the same as docker. If that does not work we can skip for now. Should I use this branch to test shpc and verify if this works or not (I think this would be a good idea over blindly merging it!)
Signed-off-by: vsoch [email protected]