Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use declare module 'vue' to fix type issues #419

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

andreasgangso
Copy link
Contributor

Changes

Use the newer syntax for adding component instance properties. The old syntax has issues on newer versions of vue. See reference.

References

vuejs/language-tools#4793 (comment)

@andreasgangso
Copy link
Contributor Author

@tusharpandey13 can you merge this? We have to maintain a fork at the moment

Copy link
Contributor

@tusharpandey13 tusharpandey13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tusharpandey13
Copy link
Contributor

tusharpandey13 commented Sep 30, 2024

Hi @andreasgangso it looks like your commit is not signed, can you rebase, sign and push again?
Thanks

@andreasgangso
Copy link
Contributor Author

@tusharpandey13 done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants