Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle 409 conflict errors with its own exception class #640

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DavidMealha-Onfido
Copy link

@DavidMealha-Onfido DavidMealha-Onfido commented Feb 4, 2025

Changes

This Pull Request doesn't change any endpoints, but does change the way the HTTP 409 error is handled by having its own exception class, this way it's easier to filter these errors on client integrations. Right now it's wrapped under the Auth0::Unsupported exception which can include multiple errors.

Given this may impact existing integration this should be a major version.

References

Testing

Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of Ruby

Checklist

@DavidMealha-Onfido DavidMealha-Onfido marked this pull request as ready for review February 4, 2025 17:51
@DavidMealha-Onfido DavidMealha-Onfido requested a review from a team as a code owner February 4, 2025 17:51
@DavidMealha-Onfido
Copy link
Author

Hello @arpit-jn @gyaneshgouraw-okta, could you have a look at this MR since you seem the most recent contributors to ruby-auth0? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant