Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new resource to manage Organization Client Grants #1027

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

duedares-rvj
Copy link
Contributor

@duedares-rvj duedares-rvj commented Sep 19, 2024

🔧 Changes

  1. Added a new resource auth0_organization_client_grant
  2. Extended data sourceauth0_organization to hold list of client grants associated.
  3. Added relevant test case and recording

📚 References

🔬 Testing

Relevant test cases which mimics the flow has been added.

make test FILTER=TestOrganizationClientGrant

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@duedares-rvj duedares-rvj requested a review from a team as a code owner September 19, 2024 14:34
@duedares-rvj duedares-rvj changed the title Client creds/extension Add new resource to manage Organization Client Grants Sep 19, 2024
@acwest acwest force-pushed the Client-Creds/extension branch 3 times, most recently from 54a671d to 32d33df Compare September 26, 2024 20:31
@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 85.34483% with 17 lines in your changes missing coverage. Please review.

Project coverage is 90.22%. Comparing base (5e982d1) to head (4bd5a57).

Files with missing lines Patch % Lines
...ternal/auth0/organization/resource_client_grant.go 81.96% 8 Missing and 3 partials ⚠️
internal/auth0/organization/data_source.go 70.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1027      +/-   ##
==========================================
- Coverage   90.25%   90.22%   -0.04%     
==========================================
  Files         112      113       +1     
  Lines       16350    16467     +117     
==========================================
+ Hits        14757    14857     +100     
- Misses       1118     1130      +12     
- Partials      475      480       +5     
Flag Coverage Δ
90.22% <85.34%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
internal/auth0/client/expand.go 96.44% <100.00%> (+0.02%) ⬆️
internal/auth0/client/flatten.go 94.40% <100.00%> (+0.01%) ⬆️
internal/auth0/client/resource_grant.go 85.29% <100.00%> (+2.53%) ⬆️
internal/auth0/organization/flatten.go 100.00% <100.00%> (ø)
internal/auth0/resourceserver/resource.go 77.20% <100.00%> (+0.48%) ⬆️
internal/provider/provider.go 100.00% <ø> (ø)
internal/auth0/organization/data_source.go 86.98% <70.00%> (-2.78%) ⬇️
...ternal/auth0/organization/resource_client_grant.go 81.96% <81.96%> (ø)

acwest
acwest previously approved these changes Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants