Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iss 330 send headers while producing to kafka #395

Conversation

Cyril-Edme
Copy link

@Cyril-Edme Cyril-Edme commented May 12, 2020

send headers while producing to kafka

PR Branch
https://github.com/Cyril-Edme/zerocode/tree/ISS-330-send-headers-while-producing-to-kafka

Motivation and Context

We should be able to send some headers in our Kafka message. As well as the consumer should be able to assert on the received headers.

Checklist:

  • Unit tests added

  • Integration tests added

  • Test names are meaningful

  • Feature manually tested

  • Branch build passed

  • No 'package.*' in the imports

  • Relevant Wiki page updated with clear instruction for the end user

    • Not applicable. This was only a refactor change, no functional or behaviour changes were introduced
  • Http test added to http-testing module(if applicable) ?

    • Not applicable. The changes did not affect HTTP automation flow
  • Kafka test added to kafka-testing module(if applicable) ?

    • Not applicable. The changes did not affect Kafka automation flow

@Cyril-Edme Cyril-Edme force-pushed the ISS-330-send-headers-while-producing-to-kafka branch from 296ec77 to 2e0e8df Compare May 12, 2020 14:19
@authorjapps
Copy link
Owner

@Cyril-Edme , We are happy to merge this unless you are adding any more stuffs like any tidy up work or any more test coverage you might have missed.
Please give us a shout if not to be merged soon by this weekend!

I have declined the other PR which looks duplicate of this and already outdated due to duplicate code.

@Cyril-Edme
Copy link
Author

@authorjapps thanks for your commit with the few fix (good to know for the next time). It's all good for me, about the partition that we discussed about in slack, it's another topic with it's own issue.

@authorjapps
Copy link
Owner

@authorjapps thanks for your commit with the few fix (good to know for the next time). It's all good for me, about the partition that we discussed about in slack, it's another topic with it's own issue.

Sure, Let's address that next...

@authorjapps
Copy link
Owner

solves #330

@authorjapps authorjapps merged commit 15bc03c into authorjapps:master May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants