ISSUE-409 # Added support for csv file in the parameterized csvSource
#476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like an awesome feature. Any plans to review and merge? @authorjapps |
|
CI Build status is here: Once Green, then will attempt to merge |
| } | ||
| ], | ||
| "parameterized": { | ||
| "csvSource":"parameterized_csv/params.csv" |
There was a problem hiding this comment.
Updated code to read from resources folder without referring to "./test/...".
Changed method impl to include Path prefix to "./test/...".
There shohuld be a better way to do this, I have put this as a quick fix. Please feel free to amend this.
There was a problem hiding this comment.
@imprashant , any news on this comment ? Or are you happy for us to merge it?
|
All look good. |
authorjapps
approved these changes
Jan 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #409
PR Branch
https://github.com/imprashant/zerocode/tree/409-csvsource-from-file
Support externalized csv files under Parameterized CSV source
This PR intends to address the problem mentioned in issue 409, to add support to fetch parameters from external csv source file.
Checklist:
Unit tests added
Integration tests added
Test names are meaningful
Feature manually tested
Branch build passed
No 'package.*' in the imports
Relevant Wiki page updated with clear instruction for the end user
Http test added to
http-testingmodule(if applicable) ?Kafka test added to
kafka-testingmodule(if applicable) ?