Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduces support for optional resource type in ResourceFilter #367

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

vroldanbet
Copy link
Contributor

This introduces support for optional resource type, recently introduced in SpiceDB 1.30.0.

since the CLI contract has ambiguity, as a tradeoff, the contract will break by requiring clients to specify colon after the resource type, in order to disambiguate with only specifying the relation. The subject-type continues to not require colon as suffix.

Tests were also added for missing permutations and the optional resource id prefix.

former implementation of bulk-delete was designed to support
deleting large amounts of relationships in a batched way.

This commit replaces the implementation that relied on ReadRelationships
with the new native DeleteRelationships optional-limit.

The contract is kept mostly intact, except the interactive prompt is removed
as it was considered bad UX. Instead, the same limits of 1000 before the
user is prompted is retained, and instead zed will fail, indicating
the user to bump the limit with the new --optional-limit flag, or
to use --force.

The --optional-limit flag sets the corresponding `DeleteRelationship` request
field, and `--force` now sets the `OptionalAllowPartialDeletions` field. If
set to true, all relationships will be deleted in batches defined by `--optional-limit`,
which continues to default to 1000 elements.

It also adds a progress bar to provide visual feedback to the user while
deletion takes place.
This introduces support for optional resource type, recently introduced
in SpiceDB 1.30.0.

since the CLI contract has ambiguity, as a tradeoff, the contract
will break by requiring clients to specify colon after
the resource type, in order to disambiguate with _only
specifying the relation_. The subject-type continues to
not require colon as suffix.

Tests were also added for missing permutations and the optional
resource id prefix.
Base automatically changed from update-bulk-delete to main April 29, 2024 16:09
An error occurred while trying to automatically change base from update-bulk-delete to main April 29, 2024 16:09
@andrii-harbour
Copy link

+1 to support feature request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants