Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements interactive restarting. In order to implement this, unfortunately the type parameters
T
andR
had to be added to theEvent
enum, since theEvent
enum now must carry a variant which can used to send anInjector<T, R>
back to theEvent
source. This means type inference fails a bit more easily now, and adds some boilerplate to type annotations in certain situations. However, overall, having the type parametersT
andR
now accessible to theEvent
enum means adding new variants in the future involving the renderer or the picker item type will be non-breaking.The interactive restarting was otherwise quite simple to implement inside the picker (just restart, and send a new injector down the channel). However incorporating it into an application can be a bit more work. Therefore I added reasonably comprehensive examples
restart
andrestart_ext
which demonstrate how this might be done in practice and why the API has the shape that it does.