feat/react-global (#261)

* feat: add default value standalone * feat: add default value standalone * feat: add default value standalone in build file * feat: changeset
autoguru-au · Jun 12, 2024 · 51cbd2b · 51cbd2b
1 parent e037e51
commit 51cbd2b
Show file tree

Hide file tree

Showing 6 changed files with 15 additions and 5 deletions.
diff --git a/.changeset/lovely-monkeys-marry.md b/.changeset/lovely-monkeys-marry.md
@@ -0,0 +1,5 @@
+---
+'gdu': patch
+---
+
+Add standalone flag in build file
diff --git a/.changeset/polite-ghosts-speak.md b/.changeset/polite-ghosts-speak.md
@@ -0,0 +1,5 @@
+---
+'gdu': patch
+---
+
+Add default standalone value
diff --git a/packages/gdu/commands/build/buildSPA.ts b/packages/gdu/commands/build/buildSPA.ts
@@ -10,7 +10,7 @@ export const buildSPA = async (guruConfig: GuruConfig, tenant: string) => {
 
 	// eslint-disable-next-line unicorn/prefer-prototype-methods
 	const webpackConfigs: Configuration[] = hooks.webpackConfig.call(
-		makeWebpackConfig(void 0, false, tenant),
+		makeWebpackConfig(void 0, false, tenant, guruConfig?.standalone),
 	);
 
 	const compiler = webpack(webpackConfigs);

diff --git a/packages/gdu/commands/start/runSPA.ts b/packages/gdu/commands/start/runSPA.ts
@@ -40,7 +40,7 @@ export const runSPA = async (guruConfig: GuruConfig, isDebug) => {
 
 	// eslint-disable-next-line unicorn/prefer-prototype-methods
 	const webpackConfig: Configuration = hooks.webpackConfig
-		.call(webpackConfigs(appEnv, isDebug, null, guruConfig.standalone))
+		.call(webpackConfigs(appEnv, isDebug, null, guruConfig?.standalone))
 		.find(({ name }) => name === appEnv);
 
 	const consumerHtmlTemplate = getConsumerHtmlTemplate(guruConfig);

diff --git a/packages/gdu/config/webpack/index.ts b/packages/gdu/config/webpack/index.ts
@@ -9,7 +9,7 @@ const buildConfigs = (
 	env = process.env.APP_ENV,
 	isDebug: boolean,
 	tenant?: string,
-	standalone?: boolean,
+	standalone: boolean = true,
 ): Configuration[] => {
 	const buildEnvs = getBuildEnvs(env);
 	return buildEnvs.map((buildEnv) => ({

diff --git a/packages/gdu/config/webpack/webpack.config.ts b/packages/gdu/config/webpack/webpack.config.ts
@@ -82,7 +82,7 @@ export const baseOptions = (
 	buildEnv,
 	isMultiEnv: boolean,
 	isDebug = false,
-	standalone = true,
+	standalone?: boolean,
 ): Configuration => {
 	const guruConfig = getGuruConfig();
 	return {
@@ -428,7 +428,7 @@ export const makeWebpackConfig = (
 	buildEnv: BuildEnv,
 	isMultiEnv: boolean,
 	tenant?: string,
-	standalone = true,
+	standalone?: boolean,
 ): Configuration => {
 	const { outputPath, isTenanted } = getGuruConfig();
 	return {