Skip to content

Commit

Permalink
feat: Adds assetPrefix support for nextjs MFEs
Browse files Browse the repository at this point in the history
  • Loading branch information
amir-zahedi committed Oct 1, 2024
1 parent 369596c commit 521fd43
Show file tree
Hide file tree
Showing 5 changed files with 20 additions and 8 deletions.
6 changes: 3 additions & 3 deletions packages/babel-preset/react/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@ module.exports = function autoGuruReactPreset(api, options = {}) {
],
plugins: [
!dev &&
require.resolve(
'@babel/plugin-transform-react-constant-elements',
),
require.resolve(
'@babel/plugin-transform-react-constant-elements',
),
dev && experimental && require.resolve('./plugins/named-memo.js'),
].filter(Boolean),
};
Expand Down
5 changes: 4 additions & 1 deletion packages/gdu/commands/build/buildSSR.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,10 @@ export const buildSSR = async (guruConfig: GuruConfig) => {
logger.error('response', {
processingTime: Date.now() - start,
responseHeaders: Object.fromEntries(
Object.entries(typeof error.getHeaders === 'function' && error.getHeaders()),
Object.entries(
typeof error.getHeaders === 'function' &&
error.getHeaders(),
),
),
url: 'incomingPath',
statusCode: error.statusCode,
Expand Down
10 changes: 8 additions & 2 deletions packages/gdu/commands/lint/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,10 @@ export default async () => {
logger.error('response', {
processingTime: Date.now() - start,
responseHeaders: Object.fromEntries(
Object.entries(typeof error.getHeaders === 'function' && error.getHeaders()),
Object.entries(
typeof error.getHeaders === 'function' &&
error.getHeaders(),
),
),
url: 'incomingPath',
statusCode: error.statusCode,
Expand Down Expand Up @@ -71,7 +74,10 @@ export default async () => {
logger.error('response', {
processingTime: Date.now() - start,
responseHeaders: Object.fromEntries(
Object.entries(typeof error.getHeaders === 'function' && error.getHeaders()),
Object.entries(
typeof error.getHeaders === 'function' &&
error.getHeaders(),
),
),
url: 'incomingPath',
statusCode: error.statusCode,
Expand Down
5 changes: 4 additions & 1 deletion packages/gdu/config/ssr/server.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,10 @@ export const run = async (port: number) => {
logger.error('response', {
processingTime: Date.now() - start,
responseHeaders: Object.fromEntries(
Object.entries(typeof error.getHeaders === 'function' && error.getHeaders()),
Object.entries(
typeof error.getHeaders === 'function' &&
error.getHeaders(),
),
),
url: 'incomingPath',
statusCode: error.statusCode,
Expand Down
2 changes: 1 addition & 1 deletion packages/gdu/config/webpack/webpack.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -406,7 +406,7 @@ const getPublicPath = ({
if (isDev) return '/';

if (buildEnv === 'prod') {
return `#{PUBLIC_PATH_BASE}/${projectFolderName}/`
return `#{PUBLIC_PATH_BASE}/${projectFolderName}/`;
}

const folderPath = tenant
Expand Down

0 comments on commit 521fd43

Please sign in to comment.