feat(UI-1242): add warning modal for organization deletion #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RonenMars
reviewed
Jan 27, 2025
RonenMars
reviewed
Jan 28, 2025
RonenMars
reviewed
Jan 30, 2025
src/hooks/useDeleteOrganization.tsx
Outdated
Comment on lines
36
to
39
| addToast({ | ||
| message: t("table.messages.organizationDeleted", { name: organization.displayName }), | ||
| type: "success", | ||
| }); |
There was a problem hiding this comment.
Hooks are also part of the business logic, I found this article that describes it very well:
https://medium.com/design-bootcamp/separating-%EF%B8%8F-business-logic-from-ui-components-in-react-18-aa1775b3caba
Business logic shouldn't be mixed with the UI layer.
✅ Deploy Preview for kittest ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the user has projects (1 or more) in the deleted organization, display an error modal - "To delete the organization, you have to delete all projects in it first".
If the user has 0 projects in the organization, display the regular delete modal.
Linear Ticket
https://linear.app/autokitteh/issue/UI-1242/block-organization-delete-if-it-has-active-projects
What type of PR is this? (check all applicable)