Add syncPolicy callback for per-document authorization #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twop
reviewed
Jun 9, 2024
| @@ -85,6 +85,18 @@ export class CollectionSynchronizer extends Synchronizer { | |||
| ) | |||
|
|
|||
| const documentId = message.documentId | |||
| const senderId = message.senderId | |||
| const okToSync = await this.repo.syncPolicy(senderId, documentId) | |||
There was a problem hiding this comment.
was casually observing Discord and took a look at the PR, hence pardon my intrusion, just wanted to mention that await somePromise will always put a new event into the event loop at the very end, thus even an innocent no-op (like async () => true) can create a lot of latency if the event loop is busy/saturated. So it is possible that it might be better to make it optional and thus not awaiting as the default behavior.
pvh
force-pushed
the
main
branch
2 times, most recently
from
e61f8e3
to
d3d1a7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
syncPolicycallback to the repo configuration. It will be called whenever a sync message is received from a peer, and if it returns false, syncing will be blocked, and the repo will respond with adoc-unavailablemessage.Currently, if
sharePolicyreturns true, the repo will still send sync messages to peers even ifsyncPolicywould return false. If this is undesirable, another possibility is to only share ifsyncPolicyandsharePolicyboth return true.