Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#594 fix setup issue with sklearn #596

Merged
merged 4 commits into from
Apr 20, 2024

Conversation

mikkokotila
Copy link
Contributor

You want to make a PR to Talos

Thanks so much :) First, please take a moment to carefully check through
the below items:

Sanity

  • I'm aware of the implications of the proposed changes
  • Code is PEP8
  • I'm making the PR to master
  • I've updated the versions based on Semantic Versioning
    • setup.py
    • talos/__init__.py
    • docs/index.html
    • docs/_coverpage.md

Docs

Tests

  • Changes have gone through actual use testing
  • All local tests have passed (run ./test.sh in /talos)
  • Tests have been updated to reflect the changes

closes #594

@pep8speaks
Copy link

Hello @mikkokotila! Thanks for opening this PR.

Line 11:58: W291 trailing whitespace

Line 5:1: F401 '.scan.Scan.Scan' imported but unused
Line 6:1: F401 '.commands.analyze.Analyze' imported but unused
Line 7:1: F401 '.commands.analyze.Analyze as Reporting' imported but unused
Line 8:1: F401 '.commands.predict.Predict' imported but unused
Line 9:1: F401 '.commands.deploy.Deploy' imported but unused
Line 10:1: F401 '.commands.evaluate.Evaluate' imported but unused
Line 11:1: F401 '.commands.restore.Restore' imported but unused
Line 14:1: F401 '.utils' imported but unused
Line 16:1: F401 '.autom8' imported but unused
Line 17:1: F401 '.callbacks' imported but unused
Line 35:5: F821 undefined name 'commands'
Line 35:15: F821 undefined name 'scan'
Line 35:21: F821 undefined name 'model'
Line 35:28: F821 undefined name 'metrics'

Do see the Hitchhiker's guide to code style

@mikkokotila mikkokotila merged commit a135847 into master Apr 20, 2024
0 of 4 checks passed
@mikkokotila mikkokotila deleted the #594_fix_setup_issue_with_sklearn branch April 20, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pip install talos is failing due to sklearn in requirements.txt instead of scikit-learn
2 participants