Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connect a wallet to the api and add balance and transfer function #20

Merged
merged 24 commits into from
Jun 12, 2024
Merged

Connect a wallet to the api and add balance and transfer function #20

merged 24 commits into from
Jun 12, 2024

Conversation

marc-aurele-besner
Copy link
Member

Connect a wallet to the api and add balance and transfer function

  • Attach a wallet from extension, mnemonic or seed
  • Query balance
  • Execute a transfer
  • Test all of the above

@marc-aurele-besner marc-aurele-besner linked an issue Jun 6, 2024 that may be closed by this pull request
Connect a wallet to the API and add a transfer function #4
Closed
abhi3700
abhi3700 reviewed Jun 7, 2024
View reviewed changes
Copy link
Contributor

@abhi3700 abhi3700 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some are minor out of all.

packages/auto-consensus/__test__/balances.test.ts Outdated Show resolved Hide resolved
packages/auto-consensus/__test__/balances.test.ts Show resolved Hide resolved
packages/auto-consensus/__test__/info.test.ts Show resolved Hide resolved
packages/auto-consensus/src/balances.ts Outdated Show resolved Hide resolved
packages/auto-consensus/src/balances.ts Outdated Show resolved Hide resolved
packages/auto-utils/__test__/wallet.test.ts Show resolved Hide resolved
packages/auto-utils/__test__/wallet.test.ts Show resolved Hide resolved
packages/auto-utils/__test__/wallet.test.ts Outdated Show resolved Hide resolved
packages/auto-utils/src/wallet.ts Outdated Show resolved Hide resolved
packages/auto-utils/src/wallet.ts Outdated Show resolved Hide resolved
abhi3700
abhi3700 approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@abhi3700 abhi3700 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marc-aurele-besner marc-aurele-besner added auto-consensus Anything related to Auto-Consensus auto-utils Any common functions between consensus & auto-id labels Jun 10, 2024
@marc-aurele-besner marc-aurele-besner merged commit 9ebf2bd into main Jun 12, 2024
3 checks passed
@marc-aurele-besner marc-aurele-besner deleted the 4-connect-a-wallet-to-the-api-and-add-a-transfer-function branch June 12, 2024 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfrank-summit jfrank-summit jfrank-summit approved these changes

@abhi3700 abhi3700 abhi3700 approved these changes

Assignees
No one assigned
Labels
auto-consensus Anything related to Auto-Consensus auto-utils Any common functions between consensus & auto-id
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Connect a wallet to the API and add a transfer function
3 participants
@marc-aurele-besner @abhi3700 @jfrank-summit