Feat/af memory pruning #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I actually overlooked the current structure. The memory is not an issue for most of them because in reducer we only keep the new data. So we only need pruner for |
jfrank-summit
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following issue #127. Memory Pruner script with its test codes are in this PR. Now, memry pruner is a function at the end of the workflow.
The upper bound of the memory will be
MAX_PROCESSED_IDSandMAX_PROCESSED_IDSover the lastMAX_AGE_IN_DAYS.P.S: This PR developed on top of two un-merged branches. We have to merge PRs #125, #126, and #130 first.