Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweet Processing Enhancements #134

Merged
merged 9 commits into from
Jan 14, 2025
Merged

Conversation

jfrank-summit
Copy link
Member

This PR addresses two cases where not enough info regarding a tweet was being passed to the LLM:

  • Content of quote tweets were not being included
  • Excess text in long posts was being ignored

Enhancements to tweet processing:

Improvements to data extraction functions:

Improvements to tweet conversion process:

jfrank-summit and others added 2 commits January 13, 2025 16:30
- Added functions to extract full text and quoted tweets from timeline data.
- Improved user data extraction to include profile image URL.
- Updated the tweet conversion function to include engagement metrics such as reply count, retweet count, like count, and view count.
- Refactored existing code for better readability and maintainability.
@jfrank-summit jfrank-summit requested a review from Xm0onh January 14, 2025 00:27
@jfrank-summit jfrank-summit marked this pull request as draft January 14, 2025 00:37
@jfrank-summit jfrank-summit marked this pull request as ready for review January 14, 2025 00:43
Copy link
Member

@Xm0onh Xm0onh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are having new field, could you add types as well?
Like here:

thread: z.array(z.lazy(() => dsnTweet)).optional(),

@jfrank-summit
Copy link
Member Author

Since we are having new field, could you add types as well? Like here:

thread: z.array(z.lazy(() => dsnTweet)).optional(),

I have added a type for quotedTweet and fixed an issue with failed timeline tweet conversions.

Xm0onh
Xm0onh previously approved these changes Jan 14, 2025
Copy link
Member

@Xm0onh Xm0onh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Left some questions for my understanding.

@jfrank-summit jfrank-summit merged commit d813a18 into main Jan 14, 2025
1 check passed
@jfrank-summit jfrank-summit deleted the feat/improve-timeline-conversion branch January 14, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants