-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweet Processing Enhancements #134
Conversation
- Added functions to extract full text and quoted tweets from timeline data. - Improved user data extraction to include profile image URL. - Updated the tweet conversion function to include engagement metrics such as reply count, retweet count, like count, and view count. - Refactored existing code for better readability and maintainability.
…ementation with limited utility
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we are having new field, could you add types as well?
Like here:
thread: z.array(z.lazy(() => dsnTweet)).optional(), |
I have added a type for quotedTweet and fixed an issue with failed timeline tweet conversions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Left some questions for my understanding.
…so add note tweet processing
This PR addresses two cases where not enough info regarding a tweet was being passed to the LLM:
Enhancements to tweet processing:
auto-agents-framework/src/agents/workflows/kol/nodes/engagementNode.ts
: Added handling for quoted tweets in thegetEngagementDecision
andcreateEngagementNode
functions. [1] [2]auto-agents-framework/src/agents/workflows/kol/nodes/generateTweetNode.ts
: Included quoted tweet information in thepostTweet
function.Improvements to data extraction functions:
auto-agents-framework/src/services/twitter/convertFromTimeline.ts
: Enhanced theextractLegacyData
,extractFullText
, andextractQuotedTweet
functions to handle quoted tweets and prevent infinite recursion.auto-agents-framework/src/services/twitter/convertFromTimeline.ts
: Updated theextractPhotos
andextractVideos
functions to handle cases where media is not available.Improvements to tweet conversion process:
auto-agents-framework/src/services/twitter/convertFromTimeline.ts
: Modified theconvertTimelineTweetToTweet
function to include additional tweet metadata and handle quoted tweets.