Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Orchestrator Configuration for Instance-Level Model Selection and Context Management #215

Merged
merged 17 commits into from
Feb 6, 2025

Conversation

Xm0onh
Copy link
Member

@Xm0onh Xm0onh commented Feb 6, 2025

Closes #214 and Closes #199

This pull request introduces updates to the orchestrator configuration and context size management, refactors the code to remove unnecessary dependencies, and enhances the documentation. The most important changes include the addition of context size management, dynamic configuration for the orchestrator, and refactoring to remove the VectorDB dependency from several nodes.

Documentation Updates:

  • Added a new section on context size management in README.md, detailing how to configure pruning parameters both statically and dynamically.
  • Updated the README.md to include network configuration for the Taurus EVM wallet.

Configuration Enhancements:

  • Introduced pruning parameters (maxWindowSummary and maxQueueSize) in the orchestrator configuration to manage the context window size dynamically. [1] [2] [3]

Code Refactoring:

  • Removed the VectorDB dependency from inputNode, messageSummaryNode, and workflowSummaryNode to simplify the node creation process. [1] [2] [3] [4]
  • Updated the orchestrator workflow to handle the new pruning parameters and refactored the state management accordingly. [1] [2] [3] [4] [5]

Configuration File Changes:

  • Removed the orchestrator and prompt summarizer configurations from config.example.yaml and llm.ts to streamline the configuration files. [1] [2]

These changes collectively improve the flexibility and maintainability of the orchestrator configuration and enhance the overall documentation for better usability.

@Xm0onh Xm0onh requested a review from jfrank-summit February 6, 2025 01:08
@Xm0onh Xm0onh changed the title Ref/orchestrator llm Refactor Orchestrator Configuration for Instance-Level Model Selection and Context Management Feb 6, 2025
Copy link
Member

@jfrank-summit jfrank-summit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple of comments.

src/agents/workflows/orchestrator/orchestratorWorkflow.ts Outdated Show resolved Hide resolved
src/agents/workflows/twitter/twitterAgentTool.ts Outdated Show resolved Hide resolved
@Xm0onh Xm0onh requested a review from jfrank-summit February 6, 2025 18:09
Copy link
Member

@jfrank-summit jfrank-summit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of more comments

src/agent.ts Outdated Show resolved Hide resolved
Comment on lines 76 to 81
model: LLMNodeConfiguration,
tools: (StructuredToolInterface | RunnableToolLike)[],
prompts: OrchestratorPrompts,
namespace: string,
vectorStore: VectorDB,
pruningParameters?: PruningParameters,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we just pass in OrchestratorConfig type, maybe call createOrchestratorConfig and pass result in?

Copy link
Member Author

@Xm0onh Xm0onh Feb 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a couple of inconsistency. It's not possible right now to use OrchestratorConfig directly right now for this use case. Lm get it done in a separate PR.

@Xm0onh Xm0onh requested a review from jfrank-summit February 6, 2025 22:04
Copy link
Member

@jfrank-summit jfrank-summit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Xm0onh Xm0onh merged commit d1915a3 into main Feb 6, 2025
5 checks passed
@Xm0onh Xm0onh deleted the ref/orchestrator-llm branch February 6, 2025 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants