-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Orchestrator Configuration for Instance-Level Model Selection and Context Management #215
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a couple of comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of more comments
model: LLMNodeConfiguration, | ||
tools: (StructuredToolInterface | RunnableToolLike)[], | ||
prompts: OrchestratorPrompts, | ||
namespace: string, | ||
vectorStore: VectorDB, | ||
pruningParameters?: PruningParameters, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we just pass in OrchestratorConfig
type, maybe call createOrchestratorConfig
and pass result in?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found a couple of inconsistency. It's not possible right now to use OrchestratorConfig
directly right now for this use case. Lm get it done in a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Closes #214 and Closes #199
This pull request introduces updates to the orchestrator configuration and context size management, refactors the code to remove unnecessary dependencies, and enhances the documentation. The most important changes include the addition of context size management, dynamic configuration for the orchestrator, and refactoring to remove the
VectorDB
dependency from several nodes.Documentation Updates:
README.md
, detailing how to configure pruning parameters both statically and dynamically.README.md
to include network configuration for the Taurus EVM wallet.Configuration Enhancements:
maxWindowSummary
andmaxQueueSize
) in the orchestrator configuration to manage the context window size dynamically. [1] [2] [3]Code Refactoring:
VectorDB
dependency frominputNode
,messageSummaryNode
, andworkflowSummaryNode
to simplify the node creation process. [1] [2] [3] [4]Configuration File Changes:
config.example.yaml
andllm.ts
to streamline the configuration files. [1] [2]These changes collectively improve the flexibility and maintainability of the orchestrator configuration and enhance the overall documentation for better usability.