Merge pull request #1851 from subspace/tiny-ux-improvements

Tiny UX improvements
autonomys · Aug 21, 2023 · 8749269 · 8749269
2 parents c93e9f5 + e2a5c14
commit 8749269
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/crates/subspace-farmer/src/single_disk_farm.rs b/crates/subspace-farmer/src/single_disk_farm.rs
@@ -899,6 +899,7 @@ impl SingleDiskFarm {
                             erasure_coding,
                             handlers,
                             modifying_sector_index,
+                            target_sector_count,
                             sectors_to_plot_receiver,
                         )
                         .await
@@ -1233,6 +1234,8 @@ impl SingleDiskFarm {
     /// Check the farm for corruption and repair errors (caused by disk errors or something else),
     /// returns an error when irrecoverable errors occur.
     pub fn scrub(directory: &Path) -> Result<(), SingleDiskFarmScrubError> {
+        let span = Span::current();
+
         let info = {
             let file = directory.join(SingleDiskFarmInfo::FILE_NAME);
             info!(path = %file.display(), "Checking info file");
@@ -1445,6 +1448,8 @@ impl SingleDiskFarm {
                     (sector_metadata_bytes, piece)
                 },
                 |(sector_metadata_bytes, piece), sector_index| {
+                    let _span_guard = span.enter();
+
                     let offset = RESERVED_PLOT_METADATA
                         + u64::from(sector_index) * sector_metadata_size as u64;
                     if let Err(error) = metadata_file.read_exact_at(sector_metadata_bytes, offset) {
@@ -1628,9 +1633,12 @@ impl SingleDiskFarm {
                 },
             )
             .try_for_each({
+                let span = &span;
                 let checked_sectors = AtomicUsize::new(0);
 
                 move |result| {
+                    let _span_guard = span.enter();
+
                     let checked_sectors = checked_sectors.fetch_add(1, Ordering::Relaxed);
                     if checked_sectors > 1 && checked_sectors % 10 == 0 {
                         info!(
@@ -1677,6 +1685,8 @@ impl SingleDiskFarm {
             (0..number_of_cached_elements)
                 .into_par_iter()
                 .map_with(vec![0; element_size], |element, cache_offset| {
+                    let _span_guard = span.enter();
+
                     let offset = cache_offset * element_size as u64;
                     if let Err(error) = cache_file.read_exact_at(element, offset) {
                         warn!(
@@ -1726,9 +1736,12 @@ impl SingleDiskFarm {
                     Ok(())
                 })
                 .try_for_each({
+                    let span = &span;
                     let checked_elements = AtomicUsize::new(0);
 
                     move |result| {
+                        let _span_guard = span.enter();
+
                         let checked_elements = checked_elements.fetch_add(1, Ordering::Relaxed);
                         if checked_elements > 1 && checked_elements % 1000 == 0 {
                             info!(

diff --git a/crates/subspace-farmer/src/single_disk_farm/plotting.rs b/crates/subspace-farmer/src/single_disk_farm/plotting.rs
@@ -94,6 +94,7 @@ pub(super) async fn plotting<NC, PG, PosTable>(
     erasure_coding: ErasureCoding,
     handlers: Arc<Handlers>,
     modifying_sector_index: Arc<RwLock<Option<SectorIndex>>>,
+    target_sector_count: u16,
     mut sectors_to_plot: mpsc::Receiver<(SectorIndex, oneshot::Sender<()>)>,
 ) -> Result<(), PlottingError>
 where
@@ -225,7 +226,11 @@ where
         if maybe_old_plotted_sector.is_some() {
             info!(%sector_index, "Sector replotted successfully");
         } else {
-            info!(%sector_index, "Sector plotted successfully");
+            info!(
+                %sector_index,
+                "Sector plotted successfully ({:.2}%)",
+                (sector_index + 1) as f32 / target_sector_count as f32 * 100.0
+            );
         }
 
         handlers