Domain registry for domains v2 #1614

NingLin-P · 2023-06-28T18:19:31Z

#close #1591

This PR implements Domain registry as described in the V2 Domains spec

There are some TODOs left regarding to #1612.

Code contributor checklist:

I have read, understood and followed contributing guide

crates/pallet-domains/src/domain_registry.rs

crates/subspace-runtime/src/lib.rs

crates/sp-domains/Cargo.toml

crates/pallet-domains/src/lib.rs

crates/pallet-domains/src/domain_registry.rs

liuchengxu · 2023-06-30T03:39:26Z

crates/pallet-domains/src/domain_registry.rs

+    // TODO: initialize the genesis block in the domain block tree once we can drive the
+    // genesis ER from genesis config through host function


Same as genesis_block_hash, the genesis ER is initialized on the instantiation, not the genesis block.

The genesis block here is referring to the block in the block tree, not the actual domain block.

It's obviously confusing, I know the confusion essentially comes from the block tree though 🤷‍♂️

vedhavyas

Will do another round in a bit. Overall make sense.

Please leave stake related things with a TODO and I'll those gaps in my PR.

crates/pallet-domains/src/domain_registry.rs

NingLin-P · 2023-06-30T07:05:39Z

This PR was rebased regarding to a lot of renaming and resolving conflicts with the main branch.

These items will be used in later commit Signed-off-by: linning <[email protected]>

Required by upcoming changes, also considered changing DomainId to a type alias of u32, will be great to have some feedbacks Signed-off-by: linning <[email protected]>

Signed-off-by: linning <[email protected]>

vedhavyas

Some nits and suggestions but overall make sense!
Also noticed that there are no tests for this. Please add tests

crates/pallet-domains/src/domain_registry.rs

vedhavyas · 2023-06-30T14:56:35Z

crates/pallet-domains/src/domain_registry.rs

+#[derive(TypeInfo, Debug, Encode, Decode, Clone, PartialEq, Eq)]
+pub struct DomainConfig {
+    /// A user defined name for this domain, should be a human-readable UTF-8 encoded string.
+    pub domain_name: Vec<u8>,


Isn't there a BoundedVec for this purpose ?

No, the domain_name is constructed by the user not by the runtime, thus we still need to check it manually, and after the domain is instantiated, domain_name is not supposed to change.

vedhavyas · 2023-06-30T15:00:14Z

crates/pallet-domains/src/lib.rs

@@ -211,6 +266,10 @@ mod pallet {
        DomainRuntimeUpgraded {
            runtime_id: RuntimeId,
        },
+        DomainInstantiated {
+            domain_id: DomainId,
+            runtime_id: RuntimeId,


not sure if the runtime_id is useful here as this is part of the domain object, no ?

Runtime event is used to send notifications about changes or conditions in the runtime to external entities like users, chain explorers, or dApps. I think runtime_id is important info about the domain instance that is worth delivery (just like runtime_type in DomainRuntimeCreated event).

Not sure I agree here. Events should signal that domain was created with a specific DomainId. Rest of the information should be fetched from the state as required. If we add runtime_id then we should add runtime_type as well as just runtime_id is useless by itself since users or chain explorers or dapps will have to make state call to fetch that information.

IMO, events should hold as minimum details as possible but still points to bigger information on the state

Okay, I don't have strong opinion here, the runtime_id is removed now PTAL.

crates/pallet-domains/src/lib.rs

Signed-off-by: linning <[email protected]>

liuchengxu

A few nits, otherwise lgtm.

crates/pallet-domains/src/domain_registry.rs

liuchengxu · 2023-06-30T12:14:18Z

crates/pallet-domains/src/domain_registry.rs

+    // TODO: initialize the genesis block in the domain block tree once we can drive the
+    // genesis ER from genesis config through host function


It's obviously confusing, I know the confusion essentially comes from the block tree though 🤷‍♂️

crates/pallet-domains/src/domain_registry.rs

Signed-off-by: linning <[email protected]>

liuchengxu · 2023-07-03T05:56:19Z

crates/pallet-domains/src/lib.rs

+        type DomainInstantiationDeposit: Get<BalanceOf<Self>>;
+
+        /// The currency trait.
+        type Currency: LockableCurrency<Self::AccountId, Moment = Self::BlockNumber>;


I just realize that we shouldn't continue using LockableCurrency as it has been deprecated since paritytech/substrate#12951. Now that we're starting the domains from scratch, better not use the deprecated interfaces from day one. Non-blocker, can be resolved in another PR after. cc @vedhavyas

Okay, will resolve it in my upcoming PR.

Signed-off-by: linning <[email protected]>

…pace#1614

NingLin-P requested review from liuchengxu, nazar-pc, rg3l3dr and vedhavyas as code owners June 28, 2023 18:19

NingLin-P force-pushed the domain-registry branch from 3745fbb to 285919d Compare June 29, 2023 16:55

liuchengxu reviewed Jun 30, 2023

View reviewed changes

vedhavyas reviewed Jun 30, 2023

View reviewed changes

crates/pallet-domains/src/domain_registry.rs Outdated Show resolved Hide resolved

NingLin-P force-pushed the domain-registry branch from 285919d to 21c06d8 Compare June 30, 2023 07:03

NingLin-P force-pushed the domain-registry branch from 21c06d8 to ea2257f Compare June 30, 2023 12:52

NingLin-P added 4 commits June 30, 2023 21:13

Add domain registry specific config items to pallet-domains

e834db5

These items will be used in later commit Signed-off-by: linning <[email protected]>

Impl CheckedAdd for DomainId

c6a0ae1

Required by upcoming changes, also considered changing DomainId to a type alias of u32, will be great to have some feedbacks Signed-off-by: linning <[email protected]>

Add domain registry types, storage items and the instantiate_domain call

82db2c8

Signed-off-by: linning <[email protected]>

Instantiate the genesis domain in the pallet-domains genesis_build

e0eed54

Signed-off-by: linning <[email protected]>

NingLin-P force-pushed the domain-registry branch from ea2257f to e0eed54 Compare June 30, 2023 13:16

Merge branch 'main' into domain-registry

a94da1a

vedhavyas reviewed Jun 30, 2023

View reviewed changes

NingLin-P added 2 commits July 1, 2023 02:32

Apply review suggestions

473fdcf

Signed-off-by: linning <[email protected]>

Add test test_domain_instantiation

56ff72b

Signed-off-by: linning <[email protected]>

liuchengxu reviewed Jul 1, 2023

View reviewed changes

NingLin-P added 2 commits July 3, 2023 03:07

Apply review suggestions

44ecc6b

Signed-off-by: linning <[email protected]>

Merge branch 'main' of github.com:subspace/subspace into domain-registry

087aabc

liuchengxu previously approved these changes Jul 3, 2023

View reviewed changes

NingLin-P enabled auto-merge July 3, 2023 06:08

NingLin-P added 2 commits July 3, 2023 18:15

Merge branch 'main' into domain-registry

296507c

Apply review suggestions

71b4487

Signed-off-by: linning <[email protected]>

NingLin-P dismissed liuchengxu’s stale review via 71b4487 July 3, 2023 12:00

Merge branch 'main' into domain-registry

465b4bb

liuchengxu approved these changes Jul 3, 2023

View reviewed changes

NingLin-P merged commit e1df001 into main Jul 3, 2023
9 checks passed

NingLin-P deleted the domain-registry branch July 3, 2023 14:55

NingLin-P mentioned this pull request Jul 5, 2023

Domains Staking: Operator registration and nomination #1629

Merged

1 task

ParthDesai added a commit to autonomys/subspace-pulsar-sdk that referenced this pull request Jul 13, 2023

import autonomys/subspace#1567 autonomys/subspace#1637 autonomys/subs…

1c174c2

…pace#1614

ParthDesai added a commit to autonomys/subspace-pulsar-sdk that referenced this pull request Aug 15, 2023

import autonomys/subspace#1567 autonomys/subspace#1637 autonomys/subs…

45642b6

…pace#1614

ParthDesai added a commit to autonomys/subspace-pulsar-sdk that referenced this pull request Aug 15, 2023

import autonomys/subspace#1567 autonomys/subspace#1637 autonomys/subs…

dc09dd0

…pace#1614

ParthDesai added a commit to autonomys/subspace-pulsar-sdk that referenced this pull request Aug 15, 2023

import autonomys/subspace#1567 autonomys/subspace#1637 autonomys/subs…

9d52767

…pace#1614

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Domain registry for domains v2 #1614

Domain registry for domains v2 #1614

NingLin-P commented Jun 28, 2023

liuchengxu Jun 30, 2023

NingLin-P Jun 30, 2023

liuchengxu Jun 30, 2023

vedhavyas left a comment

NingLin-P commented Jun 30, 2023

vedhavyas left a comment •

edited

Loading

vedhavyas Jun 30, 2023

NingLin-P Jun 30, 2023

vedhavyas Jun 30, 2023

NingLin-P Jun 30, 2023

vedhavyas Jul 3, 2023 •

edited

Loading

NingLin-P Jul 3, 2023

liuchengxu left a comment

liuchengxu Jun 30, 2023

liuchengxu Jul 3, 2023

NingLin-P Jul 3, 2023

		// TODO: initialize the genesis block in the domain block tree once we can drive the
		// genesis ER from genesis config through host function

Domain registry for domains v2 #1614

Domain registry for domains v2 #1614

Conversation

NingLin-P commented Jun 28, 2023

Code contributor checklist:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vedhavyas left a comment

Choose a reason for hiding this comment

NingLin-P commented Jun 30, 2023

vedhavyas left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vedhavyas Jul 3, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

liuchengxu left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vedhavyas left a comment •

edited

Loading

vedhavyas Jul 3, 2023 •

edited

Loading