Add metrics to subspace-bootstrap-node. #1856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazar-pc
reviewed
Aug 23, 2023
crates/subspace-networking/src/bin/subspace-bootstrap-node/main.rs
Outdated
Show resolved
Hide resolved
- change the metrics endpoint argument
nazar-pc
approved these changes
Aug 23, 2023
vedhavyas
pushed a commit
that referenced
this pull request
Aug 25, 2023
Add metrics to subspace-bootstrap-node.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes metrics for
subspace-bootstrap-node. When we set the new--metrics-portthe application starts serving metrics on thehttp://0.0.0.0:<metrics_port>/metricsendpoint that enables gathering internal libp2p data by prometheus and exposing it via graphana.Code contributor checklist: