-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collect the domain transaction fee and use as the operator reward #1859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pallet is used to collet all the transaction fee of all transactions included in current block, these transaction fees is used later as the operator reward. Signed-off-by: linning <[email protected]>
THe transaction fee is deducted from the transaction sender, and the total amount of balance being deducted is recorded in the pallet_domain_transaction_fees Signed-off-by: linning <[email protected]>
Signed-off-by: linning <[email protected]>
Signed-off-by: linning <[email protected]>
NingLin-P
requested review from
vedhavyas,
nazar-pc and
rg3l3dr
as code owners
August 21, 2023 21:28
vedhavyas
reviewed
Aug 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some questions on Impl but overall make sense
Signed-off-by: linning <[email protected]>
vedhavyas
reviewed
Aug 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: linning <[email protected]>
vedhavyas
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1774
This PR collects all the transaction fees that are deducted from the transaction sender and uses it as the operator reward. The changes this PR brings:
pallet-domain-transaction-fees
for tracking the transaction fees of the current domain blockpallet-domain-transaction-fees
NOTE: in Ethereum the base fee of a transaction is burned but in this PR we simply collect the base fee of evm transaction and use it as the operator reward.
Code contributor checklist: