Add consensus_block_info digest to domain block header and use it to load ER #1885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This degist contains the consensus block hash that derive the domain block, it is used in later commits to load ER. This commit also revise the sp-domain-digests to replace the deprecated primary block with consensus block and remove the consensus block number from the digest since it is useless Signed-off-by: linning <[email protected]>
…d ER This commit change to the way to load ER from using the domain_hash => consensus_hash mapping to using the consensus hash of the consensus_block_info digest Signed-off-by: linning <[email protected]>
…m the operator aux storage Signed-off-by: linning <[email protected]>
…in_block Signed-off-by: linning <[email protected]>
NingLin-P
requested review from
vedhavyas,
nazar-pc and
rg3l3dr
as code owners
Signed-off-by: linning <[email protected]>
vedhavyas
approved these changes
Aug 28, 2023
|
@NingLin-P we should also push a companion pr for gemini-3f maintenance branch |
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1871 introduced changes that when there are multiple consensus blocks mapped to a domain block, always use the ER that derives from the canonical consensus block. While this is correct for loading ER to submit with bundle, it is problematic for another use case, namely loading the parent ER when constructing an ER. In this case, it is expected to load the parent ER that is in the same fork as the under-constructing ER instead of always loading the ER from the canonical chain.
This PR adds a digest to the domain block header, which contains the hash of the
domainconsensus block that derives the domain block, and uses this digest to load ER, with this approach we can:Code contributor checklist: