Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block relay improvements (take 2) #1911

Merged
merged 7 commits into from
Aug 30, 2023
Merged

Block relay improvements (take 2) #1911

merged 7 commits into from
Aug 30, 2023

Conversation

nazar-pc
Copy link
Member

This is exactly the same as #1883 except last commit. Incremental archiver seems to be an attempt to create something similar to SCALE encoding that is not quite SCALE encoding. There are simpler/nice ways to do that, but it is ultimately completely unnecessary as the last one-liner commit here achieves the same goal of never exceeding the size limit.

All credits for implementation here go to Rahul.


  1. Add support for returning multiple complete blocks, without going through the protocol. This is meant for scenarios where a node is syncing upon start
  2. Enable block relay by default.
  3. Clean ups

Fixes #1901

Code contributor checklist:

@nazar-pc nazar-pc merged commit 263ca8a into main Aug 30, 2023
9 checks passed
@nazar-pc nazar-pc deleted the rsub/br-changes-take-2 branch August 30, 2023 20:38
@nazar-pc nazar-pc mentioned this pull request Aug 30, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support download of multiple blocks
2 participants