Update storages and types for Domains #2512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lock is confirmed
…that are planned. For now, I did not remove the actual Runtime API and will be removed in a XDM changeset itself
Marked a TODO where necessary to fetch the data from Runtime when we have XDM enabled
vedhavyas
requested review from
NingLin-P,
nazar-pc and
rg3l3dr
as code owners
1 task
nazar-pc
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has collection of specific commits from #2508 and #2510 that updates the storages and types on Domains before we enable Nova on Gemini-3h.
TODOs are marked where necessary to fill the gaps in later PRs
Code contributor checklist: