Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark for fast way to read record chunks #2593

Merged
merged 5 commits into from
Mar 11, 2024

Conversation

nazar-pc
Copy link
Member

@nazar-pc nazar-pc commented Mar 9, 2024

#2581 changed sector record chunks behavior on Windows to read the whole sector rather than individual chunks. Turns out it is not platform-specific and not one-size-fits-all.

This PR exposes two options in the API of subspace-farmer-components and implements a benchmark to pick the best one for each farm specifically, improving chances of proving in time.

Benchmark is primitive: simply tired both ways 3 times and picks whichever was the fastest all all. This is very naive, but quick and should be still representative of relative differences of both approaches relatively to each other.

Fixes #2591

Code contributor checklist:

@nazar-pc nazar-pc force-pushed the benchmark-for-fast-way-to-read-record-chunks branch from 2acd11a to 916f772 Compare March 9, 2024 05:48
@nazar-pc nazar-pc added this pull request to the merge queue Mar 11, 2024
Merged via the queue into main with commit 157847e Mar 11, 2024
9 checks passed
@nazar-pc nazar-pc deleted the benchmark-for-fast-way-to-read-record-chunks branch March 11, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to send solution to node, skipping further proving for this slot
2 participants