Benchmark for fast way to read record chunks #2593
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2581 changed sector record chunks behavior on Windows to read the whole sector rather than individual chunks. Turns out it is not platform-specific and not one-size-fits-all.
This PR exposes two options in the API of
subspace-farmer-components
and implements a benchmark to pick the best one for each farm specifically, improving chances of proving in time.Benchmark is primitive: simply tired both ways 3 times and picks whichever was the fastest all all. This is very naive, but quick and should be still representative of relative differences of both approaches relatively to each other.
Fixes #2591
Code contributor checklist: