Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility of the node with old runtime #2700

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

nazar-pc
Copy link
Member

@nazar-pc nazar-pc commented Apr 22, 2024

Imports autonomys/polkadot-sdk@44d742b to work around unexpected version bump in autonomys/polkadot-sdk@447bbc7 that is specific to our fork of Substrate.

See conversation starting at paritytech/polkadot-sdk#1781 (comment)

Code contributor checklist:

NingLin-P
NingLin-P previously approved these changes Apr 23, 2024
@nazar-pc
Copy link
Member Author

I tested locally and node was producing invalid blocks with original fix. I changed it to autonomys/polkadot-sdk@44d742b to address that.

Now I am able to produce blocks with this branch and import successfully using mar-29 release. I am not happy with the fact that we just ignore an error there and open for suggestions. It should be a temporary solution though as nodes upgrade and we do a runtime upgrade it should be possible to simply remove that hack and restore error handling.

@nazar-pc nazar-pc requested a review from NingLin-P April 23, 2024 09:39
@nazar-pc nazar-pc enabled auto-merge April 23, 2024 09:41
@nazar-pc nazar-pc requested review from vedhavyas and removed request for vedhavyas April 23, 2024 09:41
@NingLin-P
Copy link
Member

I am not happy with the fact that we just ignore an error there and open for suggestions.

IIUC the issue is previously the runtime api version in our fork is ahead of the upstream by 1. With the latest change upstream increase the version from 4 to 5 and add compatible code based on 5, but the compatible code is not working in our fork because our version is already 5 before the upgrade, so I'm thinking if it is possible to increase our version from 5 to 6 and change the compatible code based on 6 to make it working.

@nazar-pc
Copy link
Member Author

Then we'll just postpone the issue to a later date. Since the code is only used during block creation, we simply need to wait for nodes to upgrade and update runtime. I think this is a better strategy than to bump the version and have a similar tricky issue down the line.

Latest version works, I think it is not horrible enough to move forward for now.

@nazar-pc nazar-pc added this pull request to the merge queue Apr 23, 2024
Merged via the queue into main with commit d92a0f4 Apr 23, 2024
11 checks passed
@nazar-pc nazar-pc deleted the fix-compatibility-with-old-runtime branch April 23, 2024 10:54
github-merge-queue bot pushed a commit that referenced this pull request Apr 23, 2024
update domain block builder to use hack introduced in #2700
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants