-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compatibility of the node with old runtime #2700
Conversation
I tested locally and node was producing invalid blocks with original fix. I changed it to autonomys/polkadot-sdk@44d742b to address that. Now I am able to produce blocks with this branch and import successfully using |
IIUC the issue is previously the runtime api version in our fork is ahead of the upstream by 1. With the latest change upstream increase the version from 4 to 5 and add compatible code based on 5, but the compatible code is not working in our fork because our version is already 5 before the upgrade, so I'm thinking if it is possible to increase our version from 5 to 6 and change the compatible code based on 6 to make it working. |
Then we'll just postpone the issue to a later date. Since the code is only used during block creation, we simply need to wait for nodes to upgrade and update runtime. I think this is a better strategy than to bump the version and have a similar tricky issue down the line. Latest version works, I think it is not horrible enough to move forward for now. |
update domain block builder to use hack introduced in #2700
Imports autonomys/polkadot-sdk@44d742b to work around unexpected version bump in autonomys/polkadot-sdk@447bbc7 that is specific to our fork of Substrate.
See conversation starting at paritytech/polkadot-sdk#1781 (comment)
Code contributor checklist: