Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Do not enable CUDA on Windows because compilation fails for now" #3019

Merged
merged 1 commit into from
Sep 15, 2024
Merged

Revert "Do not enable CUDA on Windows because compilation fails for now" #3019

merged 1 commit into from
Sep 15, 2024

Conversation

nazar-pc
Copy link
Member

It compiles on Windows now, so d42735d is reverted here

Code contributor checklist:

teor2345
teor2345 approved these changes Sep 15, 2024
View reviewed changes
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nazar-pc nazar-pc added this pull request to the merge queue Sep 15, 2024
Merged via the queue into main with commit 92340f8 Sep 15, 2024
21 checks passed
@nazar-pc nazar-pc deleted the cuda-on-windows branch September 15, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teor2345 teor2345 teor2345 approved these changes

@shamil-gadelshin shamil-gadelshin Awaiting requested review from shamil-gadelshin

@rg3l3dr rg3l3dr Awaiting requested review from rg3l3dr rg3l3dr is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nazar-pc @teor2345