Add peer consensus for the last confirmed domain block receipt (domain snap sync). #3082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
reviewed
Oct 2, 2024
Comment on lines
+210
to
+213
| receipts_hashes | ||
| .entry(receipt_hash) | ||
| .and_modify(|count: &mut u32| *count += 1) | ||
| .or_insert(1u32); |
There was a problem hiding this comment.
Optional: this is usually written idiomatically as:
Suggested change
| receipts_hashes | |
| .entry(receipt_hash) | |
| .and_modify(|count: &mut u32| *count += 1) | |
| .or_insert(1u32); | |
| *receipts_hashes.entry(receipt_hash).or_default() += 1u32; |
Or if you want to keep and_modify:
Suggested change
| receipts_hashes | |
| .entry(receipt_hash) | |
| .and_modify(|count: &mut u32| *count += 1) | |
| .or_insert(1u32); | |
| receipts_hashes | |
| .entry(receipt_hash) | |
| .or_default() | |
| .and_modify(|count: &mut u32| *count += 1) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the last confirmed domain block execution receipt provider to return the receipt from the consensus of peers. The algorithm tries to gather multiple receipts from the neighboring peers and use the one with the maximum duplicates. It asks neighbors multiple times (
ATTEMPTS_NUMBERconstant) until it gathers the necessary amount of receipts (PEERS_THRESHOLDconstant), otherwise, it takes the existing results and deduces the most popular receipt from that data.Code contributor checklist: