Optimize cluster memory allocations #3098
Merged
+13
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both CPU and GPU plotters produce a ~1G sector as a vector. For cluster purposes we need to send it over the network in chunks.
Previously vector was chunked into slices and then slices were allocated into separate smaller vectors. This is unnecessary though and with https://docs.rs/bytes/latest/bytes/struct.Bytes.html#method.slice_ref we can reuse the same large allocation (that will not be dropped until the whole sector is sent over anyway) for sub-slices. It would have been nice if there was a
.chunks()method that producesBytesinstances directly, but we have what we have.Just something I noticed while re-reading code.
Code contributor checklist: