Refactor archiving code for incremental mapping generation #3100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
requested review from
shamil-gadelshin,
nazar-pc,
rg3l3dr and
NingLin-P
as code owners
teor2345
commented
Oct 8, 2024
Comment on lines
+504
to
+513
| // We can't tell the difference between an archiver initialized with a | ||
| // block continuation, and a spill over from a previous segment. So the | ||
| // only way to handle both cases without duplication is to skip a trailing | ||
| // continuation, then produce mappings for that continuation when the next | ||
| // block is added. (Either here or when the segment is full.) | ||
| [.., SegmentItem::BlockContinuation { .. }] => &[], | ||
| // If we've just finished the previous segment, the only item in the buffer | ||
| // is a SegmentHeader, so there are no new blocks to produce mappings for. | ||
| [SegmentItem::ParentSegmentHeader(_)] => &[], | ||
| _ => unreachable!("Caller always adds a new block; qed. {}", segment), |
There was a problem hiding this comment.
Are all the remaining cases really unreachable?
If we're not absolutely sure, I'm happy to make all these patterns skip the mappings (rather than panicking).
Comment on lines
+749
to
+756
| // No new blocks, unreachable as long as the caller added a new block | ||
| // (or we're still processing a large block continuation) | ||
| _ => { | ||
| unreachable!( | ||
| "Caller always adds a new block, or previous call adds block continuation; qed. {}", | ||
| segment, | ||
| ) | ||
| } |
There was a problem hiding this comment.
Similar question here: are we absolutely sure there are no other valid patterns?
teor2345
force-pushed
the
incremental-map
branch
from
66dda15
to
545ce28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR performs object mapping generation at the end of most blocks, rather than only at the end of a full segment.
This reduces load bursts on the mapping indexer, and reduces object submission to mapping latency.
Piece generation still requires a full segment.
Code contributor checklist: