Fix Snap sync #3208
Merged
Fix Snap sync #3208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazar-pc
requested review from
teor2345,
shamil-gadelshin,
NingLin-P and
dariolina
1 task
NingLin-P
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent change to request-response protocol supporting explicit addresses brought an unexpected issue: calling
WithPeerId::addresses()setsextend_addresses_through_behaviour = falseinternally, meaning dials triggered by requests in Snap sync (where we don't specify addresses explicitly) are all suddenly failing.autonomys/rust-libp2p@3f6238a fixed this by explicitly enabling previous behavior even if addresses are provided explicitly.
Code contributor checklist: