Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync mainnet runtime versions with taurus versions #3393

Merged
merged 2 commits into from
Feb 21, 2025

Conversation

teor2345
Copy link
Member

@teor2345 teor2345 commented Feb 18, 2025

This PR makes the runtime versions the same in the mainnet and taurus branches, so we can use runtime migration version filters reliably.

See the full discussion here:
#3360 (comment)

These changes are taken from:

The storage versions didn't need to be changed, because they are the same as those branches. We don't want to change the spec versions.

Code contributor checklist:

@teor2345 teor2345 added the execution Subspace execution label Feb 18, 2025
@teor2345 teor2345 self-assigned this Feb 18, 2025
@teor2345 teor2345 enabled auto-merge February 18, 2025 23:19
@NingLin-P
Copy link
Member

From #3360 (comment), I think what we want is to keep the storage version of Mainnet and Taurus synced but leave their spec_versions untouched.

@teor2345 teor2345 force-pushed the sync-taurus-mainnet-versions branch from 936ceb0 to 1cabe35 Compare February 21, 2025 02:31
Copy link
Member Author

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ready for another review!

@teor2345 teor2345 added this pull request to the merge queue Feb 21, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 21, 2025
@vedhavyas vedhavyas added this pull request to the merge queue Feb 21, 2025
Merged via the queue into main with commit 9156746 Feb 21, 2025
8 checks passed
@vedhavyas vedhavyas deleted the sync-taurus-mainnet-versions branch February 21, 2025 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execution Subspace execution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants