Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Unsigned pallet-subspace submit_vote to General extrinsic #3408

Merged
merged 7 commits into from
Feb 28, 2025
Merged

Migrate Unsigned pallet-subspace submit_vote to General extrinsic #3408

merged 7 commits into from
Feb 28, 2025

Conversation

vedhavyas
Copy link
Member

First migration of deprecated bare extrinsic to the new General extrinsic.
This PR migrates submit_vote unsigned extrinsic with necessary extension benchmark

Code contributor checklist:

@vedhavyas vedhavyas requested a review from teor2345 February 27, 2025 13:54
@vedhavyas vedhavyas changed the title Migrate Unsigned pallet-subspace vote to General extrinsic Migrate Unsigned pallet-subspace submit_vote to General extrinsic Feb 27, 2025
teor2345
teor2345 previously approved these changes Feb 27, 2025
View reviewed changes
Copy link
Member

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Thanks for putting the complex code in one place, and just having small trait impls copied into each runtime.

@vedhavyas vedhavyas requested a review from teor2345 February 28, 2025 08:45
@vedhavyas vedhavyas enabled auto-merge February 28, 2025 08:45
NingLin-P
NingLin-P reviewed Feb 28, 2025
View reviewed changes
Copy link
Member

@NingLin-P NingLin-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense overall, just one nit

@vedhavyas vedhavyas requested a review from NingLin-P February 28, 2025 12:04
@vedhavyas vedhavyas added this pull request to the merge queue Feb 28, 2025
Merged via the queue into main with commit 67b5c93 Feb 28, 2025
8 checks passed
@vedhavyas vedhavyas deleted the migrate-pallet-subspace-general-extrinsics branch February 28, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NingLin-P NingLin-P NingLin-P approved these changes

@nazar-pc nazar-pc Awaiting requested review from nazar-pc nazar-pc is a code owner

@teor2345 teor2345 Awaiting requested review from teor2345

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vedhavyas @teor2345 @NingLin-P